badalprasadsingh commented on code in PR #2638:
URL: https://github.com/apache/iceberg-go/pull/2638#discussion_r4628039029


##########
website/src/releases.md:
##########
@@ -100,6 +100,7 @@ Per-release notes (highlights, breaking changes, 
contributors) are published on
 - **RowDelta reports a concurrent deletion vector as a commit conflict.** If a 
concurrent commit adds a deletion vector for a data file that a `RowDelta` also 
adds one for, `Transaction.Commit` now fails with an error matching 
`table.ErrConflictingDeleteFiles`, `table.ErrCommitFailed` and 
`table.ErrTransactionUnusable`, and the transaction cannot be committed again. 
Previously, the error matched none of them and the transaction stayed usable. 
To resolve the conflict, reload the table and commit a `RowDelta` that adds one 
deletion vector merging the positions of both vectors and removes the 
concurrent one with `RemoveDeletes`.
 - **Schema JSON constructor uses the Go initialism.** Replace 
`iceberg.NewSchemaFromJsonFields` with `iceberg.NewSchemaFromJSONFields`.
 - **AWS identifiers use the Go initialism.** `glue.AwsProperties`, 
`glue.WithAwsConfig` and `glue.WithAwsProperties` become `glue.AWSProperties`, 
`glue.WithAWSConfig` and `glue.WithAWSProperties`; `sigv4.WithAwsConfig` 
becomes `sigv4.WithAWSConfig`; `utils.WithAwsConfig` and `utils.GetAwsConfig` 
become `utils.WithAWSConfig` and `utils.GetAWSConfig`; and 
`config.CatalogConfig.AwsProfile` becomes `AWSProfile`. The `aws-profile` YAML 
key is unchanged.
+- **`utils` is now `awsconfig`.** `utils.WithAWSConfig` and 
`utils.GetAWSConfig` move to `github.com/apache/iceberg-go/awsconfig` with the 
same names and behavior. Update the import path; the `utils` package is removed.

Review Comment:
   the aws initialism bullet just above still says "utils.WithAwsConfig" 
becomes "utils.WithAWSConfig", but no release will have that name
   
   better: if we can fold the two: drop the utils clause above and map the 
v0.7.0 names straight to the new ones



##########
catalog/glue/glue.go:
##########
@@ -329,7 +329,7 @@ func (c *Catalog) CreateTable(ctx context.Context, 
identifier table.Identifier,
        }
 
        // Use the catalog's AWS config, not the ambient chain, for the 
metadata write.
-       ctx = utils.WithAWSConfig(ctx, c.awsCfg)
+       ctx = awsconfig.WithAWSConfig(ctx, c.awsCfg)

Review Comment:
   nit: since every caller changes anyway, maybe drop the repeated package name 
and the Get prefix, e.g. `awsconfig.NewContext` and `awsconfig.FromContext`? 
   
   the name `WithAWSConfig` is already used by the Glue catalog option on 
lin107 and by `sigv4.WithAWSConfig` -> both configure a catalog, while this one 
stores a config in a context
   
   the decision is upto you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to