RussellSpitzer commented on code in PR #18676:
URL: https://github.com/apache/iceberg/pull/18676#discussion_r4630761739


##########
core/src/main/java/org/apache/iceberg/StatsUtil.java:
##########
@@ -267,7 +272,7 @@ static Types.StructType fieldStatsStruct(Type type, int 
baseId, MetricsModes.Met
 
     List<Types.NestedField> fields = Lists.newArrayList();
 
-    if (mode.hasBounds()) {
+    if (mode.hasBounds() && hasBounds(type)) {

Review Comment:
   nit: This reads odd to me. maybe typeHasBounds(type) 
   
   That way we read
   
   mode has bounds and type has bounds :shrug:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to