laskoviymishka opened a new pull request, #2654:
URL: https://github.com/apache/iceberg-go/pull/2654

   This adds a root-package test that runs the iceberg-verification type cases 
(table-spec/types, primitive, nested, variant and geospatial) against 
iceberg-go's type parser. Each input is read as a schema field's type. Valid 
inputs must decode to the fixture's `decoded` shape and re-serialize to 
`canonical` when one is given, and invalid inputs must be rejected. Like the 
reference tables test in #2636, it reads the checkout from 
`ICEBERG_VERIFICATION_DIR` and skips when that is unset.
   
   Two MUST cases are skipped by name, `geometry-crs84` and 
`geography-crs84-spherical`. iceberg-go drops the default CRS and algorithm 
when writing, so it emits `geometry` and `geography` where the fixtures expect 
`geometry(OGC:CRS84)` and `geography(OGC:CRS84, spherical)`. Listed cases still 
run, and the test fails once one of them passes so the entry gets removed. The 
same behavior shows up as advisory_fail on three SHOULD cases. That fix will 
come separately, since it changes the schema JSON iceberg-go writes.
   
   Against iceberg-verification at fb0be4d, 52 of the 57 cases pass and the 
other 5 skip as described. Editing a `decoded`, a `canonical` or a rejection 
input in a local copy of the fixtures makes the matching subtest fail. The test 
does not run in CI yet. Once #2636 lands, its CI step can widen its `-run` 
pattern to include this package.
   
   Part of apache/iceberg-verification#10.
   
   > AI-assisted, reviewed by a human.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to