kevinjqliu commented on code in PR #4431: URL: https://github.com/apache/iceberg-python/pull/4431#discussion_r4634697573
########## dev/spark/spark-defaults.conf: ########## @@ -33,6 +33,8 @@ spark.sql.catalog.hive.uri thrift://hive:9083 spark.sql.catalog.hive.io-impl org.apache.iceberg.aws.s3.S3FileIO spark.sql.catalog.hive.warehouse s3://warehouse/hive/ spark.sql.catalog.hive.s3.endpoint http://object-store:9000 +# Test table encryption with UnitestKMS from iceberg-core's tests jar, an in-memory KMS with static master keys +spark.sql.catalog.hive.encryption.kms-impl org.apache.iceberg.encryption.UnitestKMS Review Comment: As of Iceberg Java 1.12, only the Hive catalog supports table encryption ([`HiveCatalog`](https://github.com/apache/iceberg/blob/212aa894e919ff9fdf89160da4aadcbe6858ac01/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L135-L138)). REST catalog support is in progress in apache/iceberg#13225. I mentioned the same in `tests/integration/test_encryption.py` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
