iceberg-kitten opened a new pull request, #2658:
URL: https://github.com/apache/iceberg-go/pull/2658

   ## Why
   
   Appending Arrow `uint32(4294967295)` to an identity-partitioned Iceberg 
`long` stores the correct row but can record its partition as `-1`. A filter on 
the actual value then prunes the file.
   
   [Iceberg signed integer 
types](https://github.com/apache/iceberg/blob/3deb2b6617be2f7047a6e9b830b755f8a62e9ca3/format/spec.md#L283-L284)
 · [Partition values in 
manifests](https://github.com/apache/iceberg/blob/3deb2b6617be2f7047a6e9b830b755f8a62e9ca3/format/spec.md#L626)
 · [Java identity 
transform](https://github.com/apache/iceberg/blob/3deb2b6617be2f7047a6e9b830b755f8a62e9ca3/api/src/main/java/org/apache/iceberg/transforms/Identity.java#L66-L69)
 · [Unchecked Go 
casts](https://github.com/apache/iceberg-go/blob/f7dc20dfcf567302c443cc538839bd6421cc7312/table/partitioned_fanout_writer.go#L1278-L1283)
   
   ## What
   
   Keep the full `uint32` range when the partition source is a `long`. Reject 
unsigned values outside the destination's signed range.
   
   ## Implementation
   
   Use the partition source type to widen `uint32` to `int64` when required. 
Check signed bounds before all remaining `uint32` and `uint64` conversions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to