rdblue commented on code in PR #19030:
URL: https://github.com/apache/iceberg/pull/19030#discussion_r4636842042


##########
api/src/main/java/org/apache/iceberg/Files.java:
##########
@@ -81,7 +81,7 @@ public PositionOutputStream createOrOverwrite() {
 
     @Override
     public String location() {
-      return file.toString();
+      return file.toURI().toString();

Review Comment:
   These are needed for `TestAppend` tests to pass. In 
`Files.localOutput(String)`, the `file:` scheme is removed from the incoming 
path, so it needs to be added back here. Otherwise, the root metadata location 
is written without a scheme and is relativized using the table path, causing 
tests to fail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to