manuzhang commented on code in PR #18458:
URL: https://github.com/apache/iceberg/pull/18458#discussion_r4638148556
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -190,17 +189,6 @@ public boolean tableExists(Identifier ident) {
}
}
- /**
- * @deprecated since 1.12.0, use {@link #createTable(Identifier, TableInfo)}
instead.
- */
- @Deprecated
- @Override
- public Table createTable(
Review Comment:
We also need to override `stageCreate`, `stageReplace` and
`stageCreateOrReplace` methods with the `Columns[]` parameter from the base
class. I'm thinking this is worth it, since these methods won't be removed in
the future Spark 4.1.x releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]