iceberg-kitten opened a new pull request, #2662: URL: https://github.com/apache/iceberg-go/pull/2662
## Why A delete committed after compaction scans its inputs can be lost if it lands before the rewrite transaction opens. The source file is still live, and a successful `replace` can bring the deleted row back. The spec requires compaction to preserve the visible rows. [Snapshot operation](https://github.com/apache/iceberg/blob/95aac2f4b100db7f8f37563d58d09daf01196d47/format/spec.md#L1297-L1301) · [Commit validation](https://github.com/apache/iceberg/blob/95aac2f4b100db7f8f37563d58d09daf01196d47/format/spec.md#L1661-L1665) ## What Reject stale rewrites when a position delete or deletion vector affects a source file, or when the planning snapshot cannot be reached on the target branch. Unrelated appends still go through. ## Implementation Carry the scan snapshot ID through tasks and worker results. Validate up to the rewrite transaction's base and use the existing conflict checks on retries. Coordinators can also call `ValidateFromSnapshot` directly. Java passes the starting snapshot to its rewrite and uses it to check for new deletes. [Java commit manager](https://github.com/apache/iceberg/blob/95aac2f4b100db7f8f37563d58d09daf01196d47/core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java#L94-L102) · [Java rewrite validation](https://github.com/apache/iceberg/blob/95aac2f4b100db7f8f37563d58d09daf01196d47/core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java#L135-L142) Workers decoding tasks with snapshot IDs need the updated codec. The updated codec also reads older task payloads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
