EugeneYushin commented on code in PR #16250:
URL: https://github.com/apache/iceberg/pull/16250#discussion_r4639347196


##########
core/src/main/java/org/apache/iceberg/metrics/CommitInstruments.java:
##########
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.metrics;
+
+import io.opentelemetry.api.common.Attributes;
+import io.opentelemetry.api.metrics.DoubleHistogram;
+import io.opentelemetry.api.metrics.LongCounter;
+import io.opentelemetry.api.metrics.LongGauge;
+import io.opentelemetry.api.metrics.Meter;
+import java.time.Duration;
+
+/**
+ * OpenTelemetry instruments for {@link CommitReport} metrics, keyed by {@link 
CommitMetricsResult}.
+ */
+final class CommitInstruments {
+  private final DoubleHistogram duration;
+  private final LongCounter attempts;
+  private final LongCounter addedDataFiles;
+  private final LongCounter removedDataFiles;
+  private final LongGauge totalDataFiles;
+  private final LongCounter addedDeleteFiles;
+  private final LongCounter addedEqualityDeleteFiles;
+  private final LongCounter addedPositionalDeleteFiles;
+  private final LongCounter addedDVs;
+  private final LongCounter removedDeleteFiles;
+  private final LongCounter removedEqualityDeleteFiles;
+  private final LongCounter removedPositionalDeleteFiles;
+  private final LongCounter removedDVs;
+  private final LongGauge totalDeleteFiles;

Review Comment:
   👍 to setting totals as Gauge!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to