mkroll-db commented on PR #3309: URL: https://github.com/apache/iceberg-rust/pull/3309#issuecomment-7034597912
@laskoviymishka, @blackmwk how about a follow-up PR that cleans this up across the whole trait? It would add a default body returning `FeatureUnsupported` to every `Catalog` method that some catalogs only stub, and remove those stubs: - `register_table`: stubbed in [hms][1] and [s3tables][2] - `unregister_table`: stubbed in [hms][3] and [s3tables][4] - `update_table`: stubbed in [hms][5] - `update_namespace`: stubbed in [s3tables][6] plus the matching `SessionCatalog` methods. The whole trait would then follow one convention, rather than making `unregister_table` the only method with a default in this PR. This PR keeps the current pattern, consistent with `register_table` and `purge_table`. S3Tables `drop_table` is excluded on purpose, because its stub explicitly points callers to `purge_table`. [1]: https://github.com/apache/iceberg-rust/blob/0700dfe51e2a5ea4405830f5fc6887df6659ec5d/crates/catalog/hms/src/catalog.rs#L734-L743 [2]: https://github.com/apache/iceberg-rust/blob/0700dfe51e2a5ea4405830f5fc6887df6659ec5d/crates/catalog/s3tables/src/catalog.rs#L691-L700 [3]: https://github.com/apache/iceberg-rust/blob/0700dfe51e2a5ea4405830f5fc6887df6659ec5d/crates/catalog/hms/src/catalog.rs#L745-L750 [4]: https://github.com/apache/iceberg-rust/blob/0700dfe51e2a5ea4405830f5fc6887df6659ec5d/crates/catalog/s3tables/src/catalog.rs#L702-L707 [5]: https://github.com/apache/iceberg-rust/blob/0700dfe51e2a5ea4405830f5fc6887df6659ec5d/crates/catalog/hms/src/catalog.rs#L752-L757 [6]: https://github.com/apache/iceberg-rust/blob/0700dfe51e2a5ea4405830f5fc6887df6659ec5d/crates/catalog/s3tables/src/catalog.rs#L442-L451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
