laskoviymishka commented on code in PR #29:
URL: 
https://github.com/apache/iceberg-verification/pull/29#discussion_r4640752089


##########
reference-tables/v2/primitive-types-parquet-data/README.md:
##########
@@ -0,0 +1,189 @@
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
+  -->
+
+# v2/primitive-types-parquet-data
+
+Input to `reference-tables/GenerateTables.java`. The schema and partition spec 
are
+the spec's JSON forms. The one commit appends one data file holding its rows,
+written in the spec's single-value JSON keyed by field ID, with `long` values 
as
+strings.
+
+The table holds one column of every v1 and v2 primitive type. The three decimal
+columns use each of the Parquet physical types the spec maps a decimal to:
+`int32` for precision up to 9, `int64` up to 18, and `fixed_len_byte_array`
+otherwise. A reader that decodes only one of them fails on the others. The
+`timestamp` and `timestamptz` columns differ only in the `TIMESTAMP_MICROS`
+annotation's `isAdjustedToUTC` flag, so a reader that ignores the flag returns
+one of them with the wrong type, or shifted by its local zone.
+
+Row 1 holds typical values, except that `int_col` and `long_col` hold their
+maxima and `time_col` holds `00:00:00`. Row 2 holds boundary values: the int 
and
+long minima, a negative decimal with every digit of its precision used, a date
+and timestamps one microsecond before the epoch, `23:59:59.999999`, an empty
+string and an empty binary, and an all-ones uuid and fixed. Row 1's string is
+non-ASCII and includes a character outside the Basic Multilingual Plane. Row 3
+is null in every optional column.
+
+Values are written as follows:
+
+- A decimal is the spec's decimal string, with exactly `scale` digits after the
+  point. The unscaled value of the `decimal(38, 10)` column overflows 64 bits,
+  and a string carries it without loss.
+- `fixed` and `binary` values are uppercase hex, following `CONTRIBUTING.md`.
+  The spec's example is lowercase. The generator rejects lowercase hex.
+- A `uuid` is the lowercase uuid string, as the spec says.
+- Every `float` and `double` value is exactly representable in binary32 or
+  binary64, so the decimal text decodes to one value in every language.
+
+NaN, positive and negative infinity, and -0.0 are left out. JSON cannot carry
+NaN or the infinities, and the single-value serialization does not define a 
form
+for them. A -0.0 compares equal to 0.0 under most decoded-double equality, so a
+multiset comparison would not tell them apart. These are open questions for the
+dev list.
+

Review Comment:
   Good call, added in 7b6f996225



##########
reference-tables/README.md:
##########
@@ -230,7 +230,10 @@ a read of each snapshot's live data files with no Iceberg 
library: its manifest
 list, each manifest's entries not marked `DELETED`, and the rows of each data
 file those entries name, less the positions any deletion vector that applies to
 it deletes. The rows of `v3/deletion-vector-parquet-data` were instead derived
-from its Input, and a PyIceberg 0.12.0 scan returns the same rows.
+from its Input, and a PyIceberg 0.12.0 scan returns the same rows. The rows of
+`v2/primitive-types-parquet-data` were also derived from its Input, then 
checked
+against the same read with no Iceberg library and against scans with PyIceberg,
+Iceberg Java, iceberg-go and iceberg-rust.

Review Comment:
   Fixed in 7b6f996225



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to