pvary commented on PR #19052:
URL: https://github.com/apache/iceberg/pull/19052#issuecomment-7037531638
Nice cleanup! While we are here, we can clean up a bit more. Nothing in mr
main code references iceberg-common, iceberg-orc, iceberg-parquet or
iceberg-hive-metastore directly:
- iceberg-common already comes in through iceberg-core, so its declaration
can go.
- ORC and Parquet are only needed at runtime, because iceberg-data declares
them as compileOnly.
- HiveCatalog is loaded by reflection, so iceberg-hive-metastore is also
only needed at runtime.
In the tests, TestCatalogs only uses HiveCatalog from main code, so the
hive-metastore testArtifacts aren't needed.
Something like this could work:
```
- implementation project(':iceberg-common')
implementation project(':iceberg-core')
api project(':iceberg-data')
- implementation project(':iceberg-hive-metastore')
- implementation project(':iceberg-orc')
- implementation project(':iceberg-parquet')
+ runtimeOnly project(':iceberg-hive-metastore')
+ runtimeOnly project(':iceberg-orc')
+ runtimeOnly project(':iceberg-parquet')
...
- testImplementation project(path: ':iceberg-hive-metastore',
configuration: 'testArtifacts')
+ testImplementation project(':iceberg-hive-metastore')
```
I tried this locally on top of the PR.
Could be a follow-up though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]