DerGut commented on code in PR #3703:
URL: https://github.com/apache/iceberg-rust/pull/3703#discussion_r4641841880


##########
crates/catalog/rest/src/catalog.rs:
##########


Review Comment:
   You mentioned in the PR description
   > A table returned by a commit has no labels, because the commit response 
doesn't include them; Go and C++ behave the same way. 
   
   
   That's interesting, [the 
spec](https://github.com/apache/iceberg/blob/2d89aa4f528ed8735a7b31f63507b411637dbc7b/open-api/rest-catalog-open-api.yaml#L4268-L4269)
 seems to leave this decision to the client
   > clients may ignore them, and may cache them following the response ETag.
   
   So I'm good with this, but Java as a counter example is _caching_ the labels 
and reuses them for an updated table 
([BaseTable](https://github.com/apache/iceberg/blob/2d89aa4f528ed8735a7b31f63507b411637dbc7b/core/src/main/java/org/apache/iceberg/BaseTable.java#L52)
 holding the labels is not updated during a commit). So I wonder: Is there a 
reason not to do it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to