pvary commented on code in PR #18912:
URL: https://github.com/apache/iceberg/pull/18912#discussion_r4642551032
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieViewCatalog.java:
##########
@@ -104,19 +104,33 @@ public void afterEach() throws IOException {
}
}
- @Override
- @Disabled("Pending https://github.com/apache/iceberg/pull/18912")
@ParameterizedTest(name = "purge = {0}")
@ValueSource(booleans = {false, true})
- public void dropTableThatAlreadyExistsAsView(boolean purge) {
- super.dropTableThatAlreadyExistsAsView(purge);
+ public void dropTablePreservesView(boolean purge) {
Review Comment:
Do we still need these new tests? I think we should remove them as they are
covered by the `ViewCatalogTests` tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]