linzch3 commented on code in PR #19048:
URL: https://github.com/apache/iceberg/pull/19048#discussion_r4643027108
##########
gcp/src/test/java/org/apache/iceberg/gcp/gcs/TestGcsInputFile.java:
##########
@@ -111,6 +113,24 @@ public void getLength() {
assertThat(inputFile.getLength()).isEqualTo(FILE_SIZE);
}
+ @Test
+ public void getLengthMissingBlob() {
Review Comment:
thx! applied the suggestion.
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputFile.java:
##########
@@ -64,7 +66,12 @@ static GCSInputFile fromLocation(
@Override
public long getLength() {
if (blobSize == null) {
- this.blobSize = getBlob().getSize();
Review Comment:
yeah GCSInputStream has the same problem, I'll open a follow-up PR for it
after this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]