linzch3 commented on code in PR #4429: URL: https://github.com/apache/iceberg-python/pull/4429#discussion_r4643055277
########## pyiceberg/catalog/rest/__init__.py: ########## @@ -36,6 +40,9 @@ from requests.adapters import DEFAULT_RETRIES, HTTPAdapter from tenacity import RetryCallState, retry, retry_if_exception_type, stop_after_attempt from typing_extensions import override +from urllib3.connectionpool import ConnectionPool +from urllib3.exceptions import MaxRetryError, ResponseError +from urllib3.response import BaseHTTPResponse Review Comment: thx for checking 1.26! moved the BaseHTTPResponse import under TYPE_CHECKING and _max_sleep now just uses get_backoff_time() since we never set jitter. also added a test where earlier retries already eat most of the lifetime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
