Anurag-S1ngh opened a new pull request, #4447: URL: https://github.com/apache/iceberg-python/pull/4447
<!-- Closes #4022 --> # Rationale for this change A transaction can register a producer that stages no snapshot, for example the delete half of an overwrite on an empty table. `_attempt_landed()` required a snapshot for every producer, so a commit that landed and was reported as failed was never detected. The retry then raised a validation error and deleted the manifest list and manifests of the snapshot that had already landed, leaving the table unreadable. Check the snapshot ids in the transaction's `AddSnapshotUpdate`s instead. Those are the snapshots the attempt actually tried to add. ## Are these changes tested? Yes. Two cases in `tests/table/test_commit_retry.py` simulate a lost response for an overwrite on an empty table, with the default retry budget and with zero retries. Both fail before the change and pass after it. `tests/table` passes. ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
