rdblue commented on code in PR #19050:
URL: https://github.com/apache/iceberg/pull/19050#discussion_r4647955072
##########
core/src/main/java/org/apache/iceberg/ContentStatsBackedMap.java:
##########
@@ -143,11 +145,21 @@ private static boolean isKnown(FieldStats<?> fieldStats,
Kind kind) {
case VALUE_COUNT -> fieldStats.hasValueCount();
case NULL_VALUE_COUNT -> fieldStats.hasNullValueCount();
case NAN_VALUE_COUNT -> fieldStats.hasNanValueCount();
- case LOWER_BOUND -> fieldStats.lowerBound() != null;
- case UPPER_BOUND -> fieldStats.upperBound() != null;
+ case LOWER_BOUND -> hasBound(fieldStats, fieldStats.lowerBound(),
StatsUtil.LOWER_BOUND_NAME);
+ case UPPER_BOUND -> hasBound(fieldStats, fieldStats.upperBound(),
StatsUtil.UPPER_BOUND_NAME);
Review Comment:
I don't think this needs to change. This can still produce a map. But if
there isn't enough information to produce a serialized geo bound, then it can
be null when producing the lower or upper bound value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]