smaheshwar-pltr commented on code in PR #3738:
URL: https://github.com/apache/iceberg-rust/pull/3738#discussion_r4648620085
##########
crates/iceberg/src/table.rs:
##########
@@ -334,6 +335,21 @@ impl Table {
pub fn reader_builder(&self) -> ArrowReaderBuilder {
ArrowReaderBuilder::new(self.file_io.clone(), self.runtime().clone())
}
+
+ /// Creates the location generator for the layout selected by the table
properties.
+ ///
+ /// The layout follows
+ ///
[`write.object-storage.enabled`](crate::spec::TableProperties::PROPERTY_WRITE_OBJECT_STORAGE_ENABLED);
+ /// see
[`ObjectStorageLocationGenerator`](crate::writer::file_writer::location_generator::ObjectStorageLocationGenerator)
+ /// and
[`DefaultLocationGenerator`](crate::writer::file_writer::location_generator::DefaultLocationGenerator).
+ /// Java's `write.location-provider.impl` is not supported and is ignored.
Review Comment:
Changes from https://github.com/apache/iceberg-rust/pull/3730 are included
here to show what that flow would look like with this design instead.
[This](https://github.com/smaheshwar-pltr/iceberg-rust/compare/location-generator/dyn-trait-poc...location-generator/dyn-trait-poc-custom-providers)
adds custom location providers on top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]