zhjwpku commented on code in PR #1106:
URL: https://github.com/apache/iceberg-cpp/pull/1106#discussion_r4651514605


##########
ci/scripts/build_example.sh:
##########
@@ -82,8 +82,17 @@ if [[ -z "${source_dir}" || -z "${build_type}" || -z 
"${cxx_standard}" ]]; then
     exit 2
 fi
 
+case "${cxx_standard}" in
+    *[!0-9]*)
+        echo "--cxx-standard must be numeric, got '${cxx_standard}'" >&2
+        exit 2
+        ;;
+esac

Review Comment:
   The numeric check is sufficient here. An empty value is already rejected 
above, and CMake enforces a standard of 20 or newer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to