stevenzwu commented on a change in pull request #2159:
URL: https://github.com/apache/iceberg/pull/2159#discussion_r569134177
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
##########
@@ -280,11 +300,12 @@ private void completeMultiPartUpload() {
.run(s3::completeMultipartUpload);
}
- private void abortUpload() {
+ private synchronized void abortUpload() {
Review comment:
After reviewing the `abortMultipartUpload` API javadoc. We actually
shouldn't set `multipartUploadId` back to `null`. Then we also don't need the
`synchronized`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
