aokolnychyi commented on a change in pull request #2206:
URL: https://github.com/apache/iceberg/pull/2206#discussion_r569733538
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteUpdate.scala
##########
@@ -65,7 +100,7 @@ case class RewriteUpdate(spark: SparkSession) extends
Rule[LogicalPlan] with Rew
relation: DataSourceV2Relation,
scanPlan: LogicalPlan,
assignments: Seq[Assignment],
- cond: Expression): LogicalPlan = {
+ cond: Expression = Literal.TrueLiteral): LogicalPlan = {
Review comment:
When we process matched row, we know all rows must be updated. No need
for `If` expressions.
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteUpdate.scala
##########
@@ -65,7 +100,7 @@ case class RewriteUpdate(spark: SparkSession) extends
Rule[LogicalPlan] with Rew
relation: DataSourceV2Relation,
scanPlan: LogicalPlan,
assignments: Seq[Assignment],
- cond: Expression): LogicalPlan = {
+ cond: Expression = Literal.TrueLiteral): LogicalPlan = {
Review comment:
When we process matched rows, we know all rows must be updated. No need
for `If` expressions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
