rymurr commented on pull request #2203: URL: https://github.com/apache/iceberg/pull/2203#issuecomment-773347726
> > NOTE: the HiveCatalog copies a new Hadoop Configuration which is a breaking change from how the constructor used to work. See HiveMetastoreTest changes for ramifications. > > Can you be more clear? I don't see anything major. What do you mean? `setConf` of `HiveCatalog` does `new Configuration(conf)` whereas the constructor we are removing doesn't copy it. To ensure changes to hadoop configs is visible in `HiveCatalog` the user has to change or re-`setConf`. Not a huge issue and probably the correct behaviour as far as we are concerned. But it did require changing a test and may have repercussions for end users. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
