rdblue commented on a change in pull request #2167:
URL: https://github.com/apache/iceberg/pull/2167#discussion_r571340787
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -63,10 +63,12 @@
Preconditions.checkArgument(group.getFieldCount() == 1,
"Invalid list: does not contain single repeated field: %s",
group);
- GroupType repeatedElement = group.getFields().get(0).asGroupType();
+ Type repeatedElement = group.getFields().get(0);
+
Preconditions.checkArgument(repeatedElement.isRepetition(Type.Repetition.REPEATED),
"Invalid list: inner group is not repeated");
- Preconditions.checkArgument(repeatedElement.getFieldCount() <= 1,
+ Preconditions.checkArgument(repeatedElement.isPrimitive() ||
+ repeatedElement.asGroupType().getFieldCount() <= 1,
Review comment:
Nit: it would be nice to keep the expression on one line, wrapping after
`checkArgument(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
