marton-bod commented on a change in pull request #2119:
URL: https://github.com/apache/iceberg/pull/2119#discussion_r571916155
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -83,6 +83,15 @@ protected HiveMetaStoreClient reconnect(HiveMetaStoreClient
client) {
return client;
}
+ @Override
+ protected boolean isConnectionException(Exception e) {
+ if (super.isConnectionException(e) || (e != null && e instanceof
MetaException &&
+ e.getMessage().contains("Got exception:
org.apache.thrift.transport.TTransportException"))) {
Review comment:
What do you mean, how does it impact debugging? E.g. not being able to
put a breakpoint there? I don't think we should optimize for that in the source
code - less verbose is usually better. Plus for debugging purposes, you can
always stop at the return line and evaluate the boolean expression in your IDE,
or just see what which branch the execution follows after
`isConnectionException()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
