yyanyy commented on a change in pull request #1963:
URL: https://github.com/apache/iceberg/pull/1963#discussion_r572543822
##########
File path: core/src/main/java/org/apache/iceberg/avro/ValueWriters.java
##########
@@ -135,145 +150,145 @@ private NullWriter() {
@Override
public void write(Void ignored, Encoder encoder) throws IOException {
- encoder.writeNull();
+ throw new IllegalStateException("[BUG] NullWriter shouldn't be used for
writing nulls for Avro");
Review comment:
I think it won't, this was just me trying to make this fail loudly
instead of fail silently and to avoid usage confusion in code, I can revert it
back if you think it's not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
