danielcweeks commented on a change in pull request #2237:
URL: https://github.com/apache/iceberg/pull/2237#discussion_r576483658
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -88,12 +86,10 @@ public OutputFile newOutputFile(String path) {
@Override
public void deleteFile(String path) {
Review comment:
There's really no concept of a directory (in the sense that you can
recursively delete a bunch of data) in S3. Directories are just a byproduct of
whatever you use as a delimiter in listing (most typically `/` to make it look
like a filesystem structure). Some FileSystem implementation use a marker for
empty directories (e.g. `<path>_$folder$`), but that's just to workaround the
fact that there isn't such a thing.
For Iceberg, this should be safe as listing isn't used and files are all
directly referenced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
