RussellSpitzer commented on a change in pull request #2240:
URL: https://github.com/apache/iceberg/pull/2240#discussion_r577903790
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -120,6 +120,8 @@ private TableProperties() {
public static final String METRICS_MODE_COLUMN_CONF_PREFIX =
"write.metadata.metrics.column.";
public static final String DEFAULT_WRITE_METRICS_MODE =
"write.metadata.metrics.default";
public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT =
"truncate(16)";
+ public static final String SORTED_COL_DEFAULT_METRICS_MODE =
"write.metadata.sorted.metrics.default";
Review comment:
I think i'm also in favor of just making the change without a flag to
configure. Just to make configuration have one parameter less, do we really
have a lot of use cases where truncate(16) isn't the right thing to do? And if
it isn't we can just let users manually reconfigure those columns individually
if they need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
