openinx commented on pull request #2230: URL: https://github.com/apache/iceberg/pull/2230#issuecomment-781005093
> 1. this has a lot of similarity with the S3FileIO. As more services add support for Iceberg, should we extract the common logic to have a `ObjectStorageFileIO` in core? @rdblue what do you think? I think it may not worth to abstract the `ObjectStorageFileIO`. In this PR we could see that aliyun `OSSFileIO` is quite similar to aws `S3FileIO` because aliyun object storage services are defining their API which are quite similar to aws API (When I implements the OSSMockApplication, I found that most of the arguments & API names are the same), though we could make abstraction between aliyun & aws, azure & google cloud storage API will be a quite different story, we won't know whether does the abstraction match azure blob storage or GCS unless we implement the azure blob storage `FileIO` and GCS `FileIO`. > 2. I really like the approach for the mock application, but it feels that the whole thing can be published by aliyun for Iceberg to import. So just curious, any plan for that in the long term? Aliyun Object storage services team is another team in our company, seems currently they don't have the plan to maintain in their aliyun oss sdk release. For our iceberg integration work, we are just depending on few APIs so we don't have to maintain all the API from the aliyun official documents ( It's actually lightweight enough to get this OSSMockApplication in iceberg repo). Another side, according to my observation, aliyun OSS API has been relatively stable for a long time, the maintenance cost is controllable for us. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
