[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2252: Hive: removed Iceberg props should be removed from HMS table props too

Thu, 18 Feb 2021 10:11:10 -0800 


aokolnychyi commented on a change in pull request #2252:
URL: https://github.com/apache/iceberg/pull/2252#discussion_r578640528



##########
File path: 
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -258,7 +268,7 @@ private Table newHmsTable() {
   }
 
   private void setHmsTableParameters(String newMetadataLocation, Table tbl, 
Map<String, String> icebergTableProps,
-      boolean hiveEngineEnabled) {
+      Set<String> obsoleteProps, boolean hiveEngineEnabled) {

Review comment:
       nit: I know it is not very consistent throughout the codebase but I 
think the following formatting would be more aligned with the rest of the code:
   
   
![image](https://user-images.githubusercontent.com/6235869/108401585-57cba700-71d1-11eb-9155-129ea47877d1.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to