aokolnychyi commented on a change in pull request #2256:
URL: https://github.com/apache/iceberg/pull/2256#discussion_r579515420
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseSparkAction.java
##########
@@ -48,7 +48,21 @@
abstract class BaseSparkAction<R> implements Action<R> {
- protected abstract Table table();
+ private final SparkSession spark;
Review comment:
Previously, we always assumed there is going to be a table we operate
on. That's not the case with actions like snapshot and migrate. Plus, it does
not make sense to init the Java context in all actions. We can do this in
parent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
