pvary commented on a change in pull request #2217:
URL: https://github.com/apache/iceberg/pull/2217#discussion_r580448516



##########
File path: 
flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java
##########
@@ -346,7 +346,7 @@ public void testPartitionTypes() throws Exception {
     assertRecords(run(), records, typesSchema);
   }
 
-  static void assertRecords(List<Row> results, List<Record> expectedRecords, 
Schema schema) {
+  public static void assertRecords(List<Row> results, List<Record> 
expectedRecords, Schema schema) {

Review comment:
       We have something like it in the Hive tests as well, and I would guess 
Spark has one too 😄 
   Do we have some other place even more accessible?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to