aokolnychyi commented on a change in pull request #2248:
URL: https://github.com/apache/iceberg/pull/2248#discussion_r580517140
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -338,12 +330,50 @@ public boolean enableBatchRead() {
boolean hasNoDeleteFiles =
tasks().stream().noneMatch(TableScanUtil::hasDeletes);
+ boolean batchReadsEnabled = batchReadsEnabled(allParquetFileScanTasks,
allOrcFileScanTasks);
+
this.readUsingBatch = batchReadsEnabled && hasNoDeleteFiles &&
(allOrcFileScanTasks ||
(allParquetFileScanTasks && atLeastOneColumn && onlyPrimitives));
}
return readUsingBatch;
}
+ private boolean batchReadsEnabled(boolean isParquetOnly, boolean isOrcOnly) {
+ if (isParquetOnly) {
+ return isVectorizationEnabled(FileFormat.PARQUET);
+ } else if (isOrcOnly) {
+ return isVectorizationEnabled(FileFormat.ORC);
+ } else {
+ return false;
+ }
+ }
+
+ public boolean isVectorizationEnabled(FileFormat fileFormat) {
Review comment:
Sounds like we would benefit from a class that takes read options,
session config and table properties and returns the value we should use. Maybe,
worth adding in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
