rdblue commented on a change in pull request #2255: URL: https://github.com/apache/iceberg/pull/2255#discussion_r582183800
########## File path: api/src/main/java/org/apache/iceberg/actions/SnapshotUpdate.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import org.apache.iceberg.Snapshot; + +/** + * An action that produces snapshots. This interface contains common methods for all + * actions that create a new table {@link Snapshot}. + * + * @param <ThisT> the child Java API class, returned by method chaining + * @param <R> the Java type of the result produced by this action + */ +public interface SnapshotUpdate<ThisT, R> extends Action<R> { + /** + * Set a summary property in the snapshot produced by this action. + * + * @param property a String property name + * @param value a String property value + * @return this for method chaining + */ + ThisT set(String property, String value); Review comment: In other places, we use `with` and descriptive name (option, property). Should this be `withSnapshotProperty`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
