rymurr commented on a change in pull request #2268:
URL: https://github.com/apache/iceberg/pull/2268#discussion_r582667015
##########
File path: python/setup.py
##########
@@ -15,8 +15,28 @@
# specific language governing permissions and limitations
# under the License.
+import sys
+
from setuptools import setup
+DEPENDENCIES = ['botocore==1.20.14',
+ 'boto3==1.17.14',
+ 'fastavro==1.3.2',
+ 'hmsclient==0.1.1',
+ 'mmh3==3.0.0',
+ 'pyparsing==2.4.7',
+ 'python-dateutil==2.8.1',
+ 'pytz==2021.1',
+ 'requests==2.25.1',
+ 'retrying==1.3.3',
+ 'pyarrow==2.0.0'
+ ]
+
Review comment:
what are your recommendations for pinning @xhochy? I dont like having
silently failing builds or uncertain behaviour but I see your point that
pinning pytz isn't going to help anything.
I have reduced pinning to just things that could likely break the build:
avro, hmsclient, pyarrow, pyparsing. Do you think that is better or still to
harsh?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
