marton-bod commented on a change in pull request #2254: URL: https://github.com/apache/iceberg/pull/2254#discussion_r582891498
########## File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerTimezone.java ########## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr.hive; + +import java.io.IOException; +import java.text.DateFormat; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.util.Collection; +import java.util.List; +import java.util.TimeZone; +import org.apache.hadoop.hive.serde2.io.DateWritable; +import org.apache.hadoop.hive.serde2.io.TimestampWritable; +import org.apache.iceberg.FileFormat; +import org.apache.iceberg.Schema; +import org.apache.iceberg.common.DynFields; +import org.apache.iceberg.data.Record; +import org.apache.iceberg.mr.TestHelper; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.types.Types; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import static org.apache.iceberg.types.Types.NestedField.optional; +import static org.junit.runners.Parameterized.Parameter; +import static org.junit.runners.Parameterized.Parameters; + +@RunWith(Parameterized.class) +public class TestHiveIcebergStorageHandlerTimezone { + DynFields.StaticField<ThreadLocal<DateFormat>> dateFormat = DynFields.builder() + .hiddenImpl(TimestampWritable.class, "threadLocalDateFormat") + .defaultAlwaysNull() + .buildStatic(); + + DynFields.StaticField<ThreadLocal<TimeZone>> localTimeZone = DynFields.builder() + .hiddenImpl(DateWritable.class, "LOCAL_TIMEZONE") + .defaultAlwaysNull() + .buildStatic(); + + @Parameters(name = "timezone={0}") + public static Collection<Object[]> parameters() { + return ImmutableList.of( + new String[] {"America/New_York"}, + new String[] {"Asia/Kolkata"}, + new String[] {"UTC/Greenwich"} + ); + } + + private TestHiveShell shell; + + private TestTables testTables; + + @Parameter(0) + public String timezoneString; + + @Rule + public TemporaryFolder temp = new TemporaryFolder(); + + @Before + public void before() throws IOException, IllegalAccessException { + TimeZone.setDefault(TimeZone.getTimeZone(timezoneString)); + + // Magic to clean cached date format for Hive where the default timezone is used in the cached object + ThreadLocal<DateFormat> dynamicDateFormat = dateFormat.get(); + if (dynamicDateFormat != null) { + dynamicDateFormat.remove(); + } + + // Magic to clean cached local timezone for Hive where the default timezone is stored in the cached object + ThreadLocal<TimeZone> dynamicTimeZone = localTimeZone.get(); Review comment: nit: maybe we can simplify these a bit `Optional.ofNullable(localTimeZone.get()).ifPresent(ThreadLocal::remove)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
