pvary opened a new pull request #2278:
URL: https://github.com/apache/iceberg/pull/2278
During #2254 we postponed to create tests for tables where the column type
is timestamp.withZone().
This PR adds them with the appropriate tests.
The premise:
- Hive2 uses sql.Timestamp internally - which is in the LocalTimezone
- Hive3 uses hive.Timestamp internally - which is in UTC
- Iceberg timestamp.withZone() stores the values in OffsetDateTime in UTC
What I have done:
- Fixed the conversions for `IcebergTimestampWithZoneObjectInspector`
- Simplified a code a little bit for `IcebergTimestampObjectInspectorHive3`
- Added the junit tests for `SELECT`
- Had to add one more magic setting so the TimeZone is handled correctly
- Added additional check to the existing unit tests to make sure that we get
back the same string in SQL as we insert
- Had to change the unit tests for Hive2, so the expected value in the
Iceberg record is considers the TimeZone
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
