pvary commented on a change in pull request #2278:
URL: https://github.com/apache/iceberg/pull/2278#discussion_r584737620
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -323,14 +323,16 @@ public void testInsertSupportedTypes() throws IOException
{
continue;
}
String columnName = type.typeId().toString().toLowerCase() + "_column";
+ String tableName = type.typeId().toString().toLowerCase() + "_table_" +
i;
Schema schema = new Schema(required(1, "id", Types.LongType.get()),
required(2, columnName, type));
List<Record> expected = TestHelper.generateRandomRecords(schema, 5, 0L);
- Table table = testTables.createTable(shell,
type.typeId().toString().toLowerCase() + "_table_" + i,
- schema, PartitionSpec.unpartitioned(), fileFormat, expected);
+ Table table = testTables.createTable(shell, tableName, schema,
PartitionSpec.unpartitioned(), fileFormat,
+ expected);
HiveIcebergTestUtils.validateData(table, expected, 0);
Review comment:
updated javadoc, and renamed the method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
