szehon-ho commented on pull request #2240: URL: https://github.com/apache/iceberg/pull/2240#issuecomment-788939041
Hi @rdblue @aokolnychyi , so I propagated the SortOrder through the various writers as discussed, including the ones I missed before. I spent some time verifying it by unit tests (TestMergingMetrics gives good coverage for Flink/Generic/Spark AppenderFactory, and TestSparkDataWrite is an end-to-end test on Spark side). When you get a chance, let me know what you think, thanks again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
