aokolnychyi edited a comment on pull request #2255:
URL: https://github.com/apache/iceberg/pull/2255#issuecomment-790072177


   Actually, we may not need the catalog. We can simply use the identifier.
   
   ```
   public interface ActionsProvider<I> {
   
     default SnapshotTable snapshotTable(I sourceTableIdent) {
       throw new UnsupportedOperationException(this.getClass().getName() + " 
does not implement snapshotTable");
     }
   
     default MigrateTable migrateTable(I tableIdent) {
       throw new UnsupportedOperationException(this.getClass().getName() + " 
does not implement migrateTable");
     }
   ```
   
   And then we can offer methods that accept `Table` as well as `Identifier` 
for other actions.
   
   ```
     default RewriteManifests rewriteManifests(I tableIdent) {
       throw new UnsupportedOperationException(this.getClass().getName() + " 
does not implement rewriteManifests");
     }
   
     default RewriteManifests rewriteManifests(Table table) {
       throw new UnsupportedOperationException(this.getClass().getName() + " 
does not implement rewriteManifests");
     }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to