szehon-ho commented on a change in pull request #2266:
URL: https://github.com/apache/iceberg/pull/2266#discussion_r588264751
##########
File path: python/tests/hive/test_hive_tables.py
##########
@@ -157,3 +157,21 @@ def test_create_tables(client, current_call,
base_scan_schema, base_scan_partiti
current_call.return_value = tbl[0].args[0].parameters['metadata_location']
tables.load("test.test_123")
+
+
[email protected]("iceberg.hive.HiveTableOperations.refresh_from_metadata_location")
[email protected]("iceberg.hive.HiveTables.delete_file")
[email protected]("iceberg.hive.HiveTableOperations.current")
[email protected]("iceberg.hive.HiveTables.get_client")
+def test_drop_tables(client, metadata, delete_file, refresh_call, tmpdir):
Review comment:
Spent some time to add a second test, with mocking all the method calls
to test the new code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
