chenjunjiedada commented on a change in pull request #2216:
URL: https://github.com/apache/iceberg/pull/2216#discussion_r590053925
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java
##########
@@ -57,4 +57,22 @@ public RewriteFiles rewriteFiles(Set<DataFile>
filesToDelete, Set<DataFile> file
return this;
}
+
+ @Override
+ public RewriteFiles rewriteDeletes(Set<DeleteFile> deletesToDelete,
Set<DeleteFile> deletesToAdd) {
+ Preconditions.checkArgument(deletesToDelete != null &&
!deletesToDelete.isEmpty(),
+ "Files to delete cannot be null or empty");
+ Preconditions.checkArgument(deletesToAdd != null &&
!deletesToAdd.isEmpty(),
Review comment:
I understand your concern. The check is used to discard the invalid
rewrite, we don't want to continue the rewrite if there is no position delete
produced. Don't we?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
