flyrain commented on a change in pull request #2314:
URL: https://github.com/apache/iceberg/pull/2314#discussion_r591969881
##########
File path: spark/src/main/java/org/apache/iceberg/actions/Actions.java
##########
@@ -79,7 +80,8 @@ public RewriteDataFilesAction rewriteDataFiles() {
}
public ExpireSnapshotsAction expireSnapshots() {
- return new ExpireSnapshotsAction(spark, table);
+ BaseExpireSnapshotsSparkAction delegate = new
BaseExpireSnapshotsSparkAction(spark, table);
+ return new ExpireSnapshotsAction(delegate);
Review comment:
Not sure about the Iceberg deprecating process. Here is my
understanding, we need to create a new method with new return type for this
user-facing API, which can be used by user moving forward. Meanwhile we mark
this method deprecated so that user won't use it anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
