szehon-ho commented on a change in pull request #2266:
URL: https://github.com/apache/iceberg/pull/2266#discussion_r592517449
##########
File path: python/iceberg/core/base_snapshot.py
##########
@@ -127,7 +126,7 @@ def __repr__(self):
def __str__(self):
return self.__repr__()
- def get_filtered_manifest(self, path, part_filter, row_filter, columns):
- reader = ManifestReader.read(self.ops.new_input_file(path))
+ def get_filtered_manifest(self, path, part_filter=None, row_filter=None,
columns=None):
Review comment:
Hi , I didn't remove but rather added None to be the default argument
for (part_filter, row_filter, column)
They actually are not used in method itself.. but not sure if anyone was
calling with those them. I can just remove them as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
