aokolnychyi commented on pull request #2296: URL: https://github.com/apache/iceberg/pull/2296#issuecomment-797085585
@RussellSpitzer and I had a quick chat. We exclude all antlr4 dependencies except the runtime jar that is needed for parsing [here](https://github.com/apache/iceberg/blob/900476d62ea599cccfc6e01806b0f02d00ce16af/build.gradle#L962). So far, we were lucky and it did not cause any conflicts as we are using the same antlr4 version as Spark. However, what if Spark decides to change the version? Then there will be conflicts. We could exclude that jar like this PR does and rely on the jar available in Spark. However, what if Spark bumps its version to something not compatible with what we use? We won't detect it at build time. It seems the safest option is to actually shade the runtime antlr4 dep and be independent from Spark. What does everybody think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
