chenjunjiedada commented on a change in pull request #2320:
URL: https://github.com/apache/iceberg/pull/2320#discussion_r592946315



##########
File path: 
spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java
##########
@@ -159,4 +168,72 @@ public void testEqualityDeleteWithFilter() throws 
IOException {
 
     Assert.assertEquals("Table should contain no rows", 0, actual.size());
   }
+
+  @Test
+  public void testReadDeleteRow() throws IOException {

Review comment:
       Make sense to me. I plan to add an abstract function to read delete rows 
and that should be implemented in the engine specific test classes. While the 
engine specific read logic is not ready, I think we can refactor when those are 
ready.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to