RussellSpitzer commented on a change in pull request #2328:
URL: https://github.com/apache/iceberg/pull/2328#discussion_r593449223
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -199,29 +203,68 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
setHmsTableParameters(newMetadataLocation, tbl, metadata.properties(),
removedProps, hiveEngineEnabled);
persistTable(tbl, updateHiveTable);
- threw = false;
} catch (org.apache.hadoop.hive.metastore.api.AlreadyExistsException e) {
+ canCleanupMetadata = true;
throw new AlreadyExistsException("Table already exists: %s.%s",
database, tableName);
} catch (TException | UnknownHostException e) {
Review comment:
Switched it around, we have to set canCleanupMetadata to false before
calling persistTable which looks a little weird but I think overall it's a
little cleaner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
