RussellSpitzer commented on a change in pull request #2328:
URL: https://github.com/apache/iceberg/pull/2328#discussion_r593559257
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -151,12 +158,13 @@ protected void doRefresh() {
refreshFromMetadataLocation(metadataLocation);
}
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
@Override
protected void doCommit(TableMetadata base, TableMetadata metadata) {
String newMetadataLocation = writeNewMetadata(metadata, currentVersion() +
1);
boolean hiveEngineEnabled = hiveEngineEnabled(metadata, conf);
- boolean threw = true;
Review comment:
Rather than the true/false here we need the abilty to differentiate
between knowing that
1. The Commit Failed
2. The Commit Suceeded
3. We aren't sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
