jackye1995 opened a new pull request #2333:
URL: https://github.com/apache/iceberg/pull/2333


   @aokolnychyi this should probably go to 0.11.1
   
   HadoopFileIO currently does not have a no-arg constructor and could not be 
loaded by the dynamic FileIO loader. But our documentation claims it can be 
loaded, so we need to fix it asap. There are 2 ways to fix it,
   1. add a no-arg constructor to HadoopFileIO, let it implement Configurable, 
and set configuration in `setConf` method.
   2. (current approach in PR) allow the loader to load an implementation that 
has a constructor taking Hadoop configuration.
   
   To do approach 1, we need to change HadoopFileIO class variable to be not 
final, and I am a bit hesitated to do that for performance concerns, so I went 
with approach 2 for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to