pvary commented on a change in pull request #2340:
URL: https://github.com/apache/iceberg/pull/2340#discussion_r595201123
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -154,30 +151,12 @@ public DecomposedPredicate decomposePredicate(JobConf
jobConf, Deserializer dese
}
/**
- * Returns the Table FileIO serialized to the configuration.
+ * Returns the Table serialized to the configuration.
* @param config The configuration used to get the data from
- * @return The Table FileIO object
+ * @return The Table
*/
- public static FileIO io(Configuration config) {
- return
SerializationUtil.deserializeFromBase64(config.get(InputFormatConfig.FILE_IO));
- }
-
- /**
- * Returns the Table LocationProvider serialized to the configuration.
- * @param config The configuration used to get the data from
- * @return The Table LocationProvider object
- */
- public static LocationProvider location(Configuration config) {
- return
SerializationUtil.deserializeFromBase64(config.get(InputFormatConfig.LOCATION_PROVIDER));
- }
-
- /**
- * Returns the Table EncryptionManager serialized to the configuration.
- * @param config The configuration used to get the data from
- * @return The Table EncryptionManager object
- */
- public static EncryptionManager encryption(Configuration config) {
- return
SerializationUtil.deserializeFromBase64(config.get(InputFormatConfig.ENCRYPTION_MANAGER));
+ public static Table table(Configuration config) {
+ return
SerializationUtil.deserializeFromBase64(config.get(InputFormatConfig.SERIALIZED_TABLE));
Review comment:
Do we want to "cache" the table. So we do not have to deserialize it
multiple times?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
